search

idaholab / malamute

Advanced manufacturing modeling and simulation
https://mooseframework.inl.gov/malamute
GNU Lesser General Public License v2.1
9 stars 26 forks source link

Transition to MultiAppGeneralFieldNearestLocationTransfer #101

Closed cticenhour closed 9 months ago

cticenhour commented 9 months ago

refs idaholab/moose#24196

closes #100

moosebuild commented 9 months ago

Job Coverage on d8419eb wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

moosebuild commented 9 months ago

Job Documentation on d8419eb wanted to post the following:

View the site here

This comment will be updated on new commits.

jiangwen84 commented 9 months ago

@cticenhour is this just the name change? is any change to the original MultiAppNearestNodeTransfer? Since we did not TEST the results (only RunApp), I am not sure if the results change or not. Any thoughts?

cticenhour commented 9 months ago

This was a consolidation of the deprecated class into a more general one, though the behavior across MOOSE testing does not appear to change from before. I linked the MOOSE PR above if you want to take a look at the changes. Pinging @dewenyushu if she would like to run these cases to be very sure.

cticenhour commented 9 months ago

We've got quite some time to make this adjustment, so I am fine with waiting until we know the impact.

jiangwen84 commented 9 months ago

I think we can merge it for now. If @dewenyushu finds any issue, we can revisit it later. Adding new golden files will be separate PR anyway.