search

idaholab / malamute

Advanced manufacturing modeling and simulation
https://mooseframework.inl.gov/malamute
GNU Lesser General Public License v2.1
9 stars 26 forks source link

hit formatting of diemodel input files #130

Closed apb13 closed 2 weeks ago

apb13 commented 2 weeks ago

Reason

Update input files to align with current hit formatting standards in MOOSE.

Design

Use script capabilities in MOOSE to update hit formatting.

Impact

Increased input file consistency and usability.

apb13 commented 2 weeks ago

Performed comparison between the two csv files, one that was the original and another that received hit formatting, to ensure that the results were the same. Also ensured that comments were formatted correctly in the input file. Refs https://github.com/idaholab/malamute/issues/128

moosebuild commented 2 weeks ago

Job Documentation on d0a7328 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 2 weeks ago

Job Coverage on d0a7328 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

cticenhour commented 2 weeks ago

@apb13 FYI - prior comments made by you can be edited (with version control!). So if you needed to edit the original post, as in this case, you can simply click on the "three dots" on the upper right of any GitHub comment and you'll get the following panel:

image

Then click on "Edit" to edit the post and click the "Update Comment" button to save!

image

Just to be clear, you don't need to do this for this PR. I just wanted to share some GitHub tips and tricks for your future PRs!

sapitts commented 2 weeks ago

@cticenhour do you know what is going on with the Mac test for this PR by chance?

cticenhour commented 2 weeks ago

We only have a handful of "darwin-clang" (AKA Intel Mac) clients now that the Mac trashcans are no more, so it's likely just busy in the queue.