Closed moosebuild closed 1 year ago
In GitLab by @cticenhour on Dec 14, 2021, 17:54
added 1 commit
In GitLab by @cticenhour on Dec 14, 2021, 18:07
Note: this cannot be merged until idaholab/moose#17641 has made it to the MALAMUTE submodule.
In GitLab by @cticenhour on Dec 23, 2021, 19:12
added 199 commits
idaholab:devel
In GitLab by @cticenhour on Dec 23, 2021, 23:12
added 1 commit
In GitLab by @cticenhour on Jan 11, 2022, 08:15
added 109 commits
idaholab:devel
In GitLab by @cticenhour on Jun 30, 2022, 14:42
added 333 commits
idaholab:devel
In GitLab by @cticenhour on Jun 30, 2022, 14:47
added 75 commits
In GitLab by @cticenhour on Jun 30, 2022, 15:27
added 53 commits
CIVET Testing summary for f64f04d
Precheck : Failed : Clang format
Documentation : Canceled by user
Mac Test : Canceled by user
Test : Canceled by user
Test Debug : Canceled by user
Non unity build : Canceled by user
Coverage : Canceled by user
In GitLab by @cticenhour on Jun 30, 2022, 15:34
added 1 commit
Job Documentation on b622ab9 wanted to post the following:
View the site here
This comment will be updated on new commits.
CIVET Testing summary for d347be9
Precheck : Allowed to fail : Size check
Documentation : Passed
Mac Test : Passed
Test : Passed
Test Debug : Passed
Non unity build : Passed
Coverage : Passed
In GitLab by @cticenhour on Jun 30, 2022, 16:13
added 3 commits
CIVET Testing summary for ad38388
Precheck : Allowed to fail : Size check
Documentation : Passed
Mac Test : Passed
Test : Passed
Test Debug : Passed
Non unity build : Passed
Test deprecated : Passed
Coverage : Passed
In GitLab by @sapitts on Jul 11, 2022, 17:32
Commented on doc/config.yml line 57
Just incidental reordering here? Or is the documentation system order-dependent?
In GitLab by @sapitts on Jul 11, 2022, 17:32
Commented on examples/sps/marmot/sps_elec_2D.i line 1
we might want to rename this folder from marmot
to something like microstructure
to avoid any issues of apparent application conflict in case we try to open source this repository
In GitLab by @sapitts on Jul 11, 2022, 17:32
Commented on examples/sps/multiapp/diemodel/electrothermomechs/simple_geometries/run_isoPlastic_all_temperature.sh line 5
Did you intend to check in this shell script to generate these runs? Would this set of temperature dependent runs be better as a tests
type file instead of a shell script?
In GitLab by @sapitts on Jul 11, 2022, 17:32
Is there a way to use the RunApp
check input on these two files? Maybe even with "turning off" the multiapp to save time?
In GitLab by @sapitts on Jul 11, 2022, 17:32
Same check input RunApp test request here as for theoneway_controls
folder
In GitLab by @sapitts on Jul 11, 2022, 17:46
Commented on examples/sps/multiapp/yttria_thermoelectric/reference_residual/function_electricpotential/tests line 32
Are any of these tests duplicates of the ones in the oneway_coupling
or other folders? If yes, should we replace some of the input files with symlinks?
In GitLab by @sapitts on Jul 11, 2022, 17:47
Commented on scripts/drsinter_data_extraction.py line 8
2021 or 2022?
In GitLab by @sapitts on Jul 11, 2022, 17:51
I had a couple of hopefully quick questions: the most pressing is about the shell script inclusions. Other than those minor things, this merge request looks good to me
In GitLab by @cticenhour on Jul 12, 2022, 08:57
Commented on scripts/drsinter_data_extraction.py line 8
Oops I should have updated this to read 2021-2022
. This needs to be done across all of MALAMUTE, so I will put it in a future PR so that it's done all at once. EDIT: I will just add it as a commit here - no sense being silly about it :)
In GitLab by @cticenhour on Jul 12, 2022, 08:59
Commented on examples/sps/marmot/sps_elec_2D.i line 1
Will do!
In GitLab by @cticenhour on Jul 12, 2022, 10:53
Commented on examples/sps/multiapp/diemodel/electrothermomechs/simple_geometries/run_isoPlastic_all_temperature.sh line 5
I intended to check this in insofar as it was already in the files I was moving from Freya - I only adjusted the name of the app to ensure it could still be useful. If you'd like me to make a series of dependent tests to confirm the temperature dependence I can. Might need your help with the gold files.
In GitLab by @cticenhour on Jul 12, 2022, 10:54
I'll double-check to see if there's an active
parameter in the multiapp, but I thought we did a RunApp with at least one other multi-app input, so maybe we can just test it as is.
In GitLab by @cticenhour on Jul 12, 2022, 10:55
Commented on examples/sps/multiapp/yttria_thermoelectric/reference_residual/function_electricpotential/tests line 32
I will diff some of these to confirm we're not populating too many duplicates.
In GitLab by @sapitts on Jul 12, 2022, 11:47
Commented on examples/sps/multiapp/diemodel/electrothermomechs/simple_geometries/run_isoPlastic_all_temperature.sh line 5
my main concern was about checking in a shell script; if that's okay to do (and presumably is since it was already in Freya), I'd be glad to merge this in as is. I can take on migrating this capability from shell script to run tests in a separate merge request. Would you be willing to make an issue for converting this script to run tests and assign that issue to me please?
In GitLab by @cticenhour on Jul 12, 2022, 13:55
Commented on examples/sps/multiapp/diemodel/electrothermomechs/simple_geometries/run_isoPlastic_all_temperature.sh line 5
I do not mind checking in a shell script like this, when its only running the final compiled app and nothing else. I will post another message here when that issue is made.
In GitLab by @cticenhour on Jul 13, 2022, 09:06
Commented on examples/sps/multiapp/diemodel/electrothermomechs/simple_geometries/run_isoPlastic_all_temperature.sh line 5
The new issue is https://hpcgitlab.hpc.inl.gov/idaholab/malamute/-/issues/33
Please feel free to edit and add to it as you see fit!
In GitLab by @cticenhour on Jul 13, 2022, 09:07
Commented on doc/config.yml line 57
Not order dependent at all - I just wanted the modules to be in semi-alphabetical order for my own readability, though I realize I screwed up the order for EM and contact :joy:
In GitLab by @cticenhour on Jul 13, 2022, 21:49
Commented on examples/sps/marmot/sps_elec_2D.i line 1
changed this line in version 13 of the diff
In GitLab by @cticenhour on Jul 13, 2022, 21:49
Commented on scripts/drsinter_data_extraction.py line 8
changed this line in version 13 of the diff
In GitLab by @cticenhour on Jul 13, 2022, 21:49
added 4 commits
In GitLab by @cticenhour on Jul 13, 2022, 21:49
resolved all threads
In GitLab by @cticenhour on Jul 13, 2022, 21:54
@sapitts Addressed most of your comments in 70024f22, cleaned up some unit test files from the MALAMUTE template that should have been deleted a while ago in 33ec66fe, updated the copyright notice years in 057dbcdf, and removed some duplicate Dr Sinter mesh files to save some space (just over 32MB down to 18MB!) in 0f365ae2. I think we're ready for another round of review.
Job Coverage on b622ab9 wanted to post the following:
f74fea | #5 b622ab | ||||
---|---|---|---|---|---|
Total | Total | +/- | New | ||
Rate | 67.17% | 77.79% | +10.62% | 96.67% | |
Hits | 491 | 872 | +381 | 377 | |
Misses | 240 | 249 | +9 | 13 |
This comment will be updated on new commits.
In GitLab by @cticenhour on Jul 13, 2022, 22:10
added 1 commit
CIVET Testing summary for 0f365ae
Precheck : Allowed to fail : Size check
Documentation : Passed
Mac Test : Passed
Test : Passed
Test Debug : Passed
Non unity build : Canceled by user
Test deprecated : Canceled by user
Coverage : Failed : verify coverage
CIVET Testing summary for ce72d55
Precheck : Allowed to fail : Size check
Documentation : Passed
Mac Test : Passed
Test : Passed
Test Debug : Passed
Non unity build : Passed
Test deprecated : Passed
Coverage : Passed
In GitLab by @cticenhour on Jul 14, 2022, 09:34
added 1 commit
Job Precheck on b622ab9 wanted to post the following:
Warning: This PR changes repo size by 18.00 MiB.
CIVET Testing summary for b622ab9
Precheck : Allowed to fail : Size check
Documentation : Passed
Mac Test : Passed
Test : Passed
Test Debug : Passed
Non unity build : Passed
Test deprecated : Passed
Coverage : Passed
In GitLab by @sapitts on Jul 14, 2022, 16:13
resolved all threads
In GitLab by @sapitts on Jul 14, 2022, 16:13
approved this merge request
In GitLab by @sapitts on Jul 14, 2022, 16:13
mentioned in commit 2908ec25382b0fa8fe71292927123d2dcdec51f1
In GitLab by @cticenhour on Dec 14, 2021, 17:21
Merges integrate-freya -> devel
This MR adds code formerly residing in Freya to MALAMUTE. The MALAMUTE Makefile and documentation configuration were also updated to accommodate the new code and new module dependencies. Issues relevant to the history retained by moving over Freya objects, tests, and input files have been re-created in MALAMUTE for SQA reference and compliance.
Closes #5
Closes #9
Closes #10
Closes #11
Closes #12
Closes #13
Refs #14
Closes #15
Closes #16
Closes #17
Closes #19
Refs #20
Closes #21
Closes #22
Closes #23
Closes #24
Closes #25
Closes #26
Refs #29
Closes #31
Closes #32