Closed somu15 closed 3 years ago
@cbolisetti Per our discussion, I created an element_size_indicator class that will assign the element size for the block given as a MaterialProperty. Please let me know if you have suggestions.
@cbolisetti Per our discussion, I created an element_size_indicator class that will assign the element size for the block given as a MaterialProperty. Please let me know if you have suggestions.
@somu15 looks fine, needs a few minor changes. It looks like the shearwaveindicator page has some errors in the equation rendering. Can you fix that in this PR too?
@cbolisetti Per our discussion, I created an element_size_indicator class that will assign the element size for the block given as a MaterialProperty. Please let me know if you have suggestions.
@somu15 looks fine, needs a few minor changes. It looks like the shearwaveindicator page has some errors in the equation rendering. Can you fix that in this PR too?
Thanks for your comments. Yes, I will fix the shearwaveindicator page.
@cbolisetti Per our discussion, I have generalized the minimumelementsizemarker class to accept an element size value. Right now, both the element_size and indicator params are optional and have to default to some value if the user does not provide any. So, in the doc, I have made an alert note stating that if both indicator and element_size are provided, indicator will control the mesh refinement. If neither are provided, the element_size will default to one and it will control. Let me know of suggestions.
@cbolisetti Per our discussion, I have generalized the minimumelementsizemarker class to accept an element size value. Right now, both the element_size and indicator params are optional and have to default to some value if the user does not provide any. So, in the doc, I have made an alert note stating that if both indicator and element_size are provided, indicator will control the mesh refinement. If neither are provided, the element_size will default to one and it will control. Let me know of suggestions.
How about throwing an error if both or none are provided? Enforce that only one is provided.
@cbolisetti Per our discussion, I have generalized the minimumelementsizemarker class to accept an element size value. Right now, both the element_size and indicator params are optional and have to default to some value if the user does not provide any. So, in the doc, I have made an alert note stating that if both indicator and element_size are provided, indicator will control the mesh refinement. If neither are provided, the element_size will default to one and it will control. Let me know of suggestions.
How about throwing an error if both or none are provided? Enforce that only one is provided.
Both indicator and element_size will default to some value if not provided. So, if I create a mooseerror in the constructor then it gets called every time. Even if the user did not specify an element value.
Job Precheck on ede1c70 wanted to post the following:
Your code requires style changes.
A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:
curl -s https://mooseframework.inl.gov/mastodon/docs/PRs/357/style.patch | git apply -v
Alternatively, with your repository up to date and in the top level of your repository:
git clang-format 97df8563d9a3ff880a06881e108943116a8d2382
@cbolisetti I made changes based on your comments. Please let me know if further changes are required.
Job Test on b8a8a87 : invalidated by @cbolisetti
Re-running for website.
Job Test on b8a8a87 : invalidated by @cbolisetti
re-running.
Reason
Currently, the minimum_elementsize_marker class accepts indicator to perform mesh refinement. This class should also be able to accept an element_size value to perform refinement.
Design
minimum_elementsize_marker is generalized to accept an element size value to perform mesh refinement.
Impact
No impact on other objects. Ensured that existing tests pass after making modifications to the minimum_elementsize_marker.
closes #351