Adding MaterialRealCMMAux and some other changes.

idaholab / mastodon

A MOOSE app for structural dynamics, seismic analysis, and risk assessment.

https://mooseframework.inl.gov/mastodon

GNU Lesser General Public License v2.1

40 stars 52 forks source link

Adding MaterialRealCMMAux and some other changes. #376

Closed cbolisetti closed 3 years ago

cbolisetti commented 3 years ago

Makes the following changes/additions:

Add the MaterialRealCMMAux, tests, and doco.
Changes to linear spring material property variables to convert them to ColumnMajorMatrix instead, so that they are consistent with isolator materials.
Other miscellaneous changes and addressing a doco bug.

Closes #374 #356 and #326

moosebuild commented 3 years ago

Job Test on 217598f wanted to post the following:

View the site here

This comment will be updated on new commits.

cbolisetti commented 3 years ago

@somu15 can you please review this?

moosebuild commented 3 years ago

Job Precheck on 2199c99 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/mastodon/docs/PRs/376/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format a9ccdaf6572ceb7b112cd8e5c95d699ca19aa57d

cbolisetti commented 3 years ago

@somu15 thanks for the review. I was going to remove the commits on changes in material properties, but I forgot -- my bad. Those were supposed to address #356. I am not yet sure what the solution for that is, but I will leave it for now. Please check out the commits now. I added some more detail in the auxkernel doco. Note that this is similar to the RankTwoTensor auxkernel, in which the user needs to know which component of the tensor corresponds to which stress component, etc. I added some language about this in the end.

cbolisetti commented 3 years ago

@cbolisetti This looks good. One comment is, if the user requests a row/column value outside the validity range, do you want to throw a moose error in the auxkernel? Or else, what is your thought on this?

@somu15 yes, the AuxKernel will throw an error when that happens. See lines 42 and 43 of MaterialRealCMMAux.C

somu15 commented 3 years ago

@cbolisetti This looks good. One comment is, if the user requests a row/column value outside the validity range, do you want to throw a moose error in the auxkernel? Or else, what is your thought on this?

@somu15 yes, the AuxKernel will throw an error when that happens. See lines 42 and 43 of MaterialRealCMMAux.C

Sounds good! Thanks for the clarification.