search

idaholab / mastodon

A MOOSE app for structural dynamics, seismic analysis, and risk assessment.
https://mooseframework.inl.gov/mastodon
GNU Lesser General Public License v2.1
40 stars 54 forks source link

Remove use of deprecated Elem::centroid #404

Closed lindsayad closed 2 years ago

lindsayad commented 2 years ago

This actually causes a data race for the static bool did_this_already across threads which can lead to the occasional crash, which we've seen on CIVET.

Closes #403

cbolisetti commented 2 years ago

This actually causes a data race for the static bool did_this_already across threads which can lead to the occasional crash, which we've seen on CIVET.

Closes #403

That's good to know! Thanks for fixing.

moosebuild commented 2 years ago

Job Test on 37f2e76 wanted to post the following:

View the site here

This comment will be updated on new commits.

lindsayad commented 2 years ago

Ok @cbolisetti it looks like the doc target fix worked (I made that way harder than it needed to be initially!). Can I get an approval? (You can of course wait til all targets are finished 😄 )

moosebuild commented 2 years ago

Job Coverage on 37f2e76 wanted to post the following:

Coverage

a50198 #404 37f2e7
Total Total +/- New
Rate 93.87% 93.87% - 100.00%
Hits 3447 3447 - 1
Misses 225 225 - 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.