search

idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.77k stars 1.05k forks source link

make libmesh_update for the fresh cloned repo #13628

Open YaqiWang opened 5 years ago

YaqiWang commented 5 years ago

Reason

When we have a fresh-cloned MOOSE, if we do make libmesh_update, we will see bunch of lines at the beginning

/bin/sh: /Users/wangy2/projects/training/mammoth/moose/libmesh/installed/contrib/bin/libmesh-config: No such file or directory
/bin/sh: /Users/wangy2/projects/training/mammoth/moose/libmesh/installed/contrib/bin/libmesh-config: No such file or directory
/bin/sh: /Users/wangy2/projects/training/mammoth/moose/libmesh/installed/contrib/bin/libmesh-config: No such file or directory
/bin/sh: /Users/wangy2/projects/training/mammoth/moose/libmesh/installed/contrib/bin/libmesh-config: No such file or directory
/bin/sh: /Users/wangy2/projects/training/mammoth/moose/libmesh/installed/contrib/bin/libmesh-config: No such file or directory
/bin/sh: /Users/wangy2/projects/training/mammoth/moose/libmesh/installed/contrib/bin/libmesh-config: No such file or directory
/bin/sh: /Users/wangy2/projects/training/mammoth/moose/libmesh/installed/contrib/bin/libmesh-config: No such file or directory
/bin/sh: /Users/wangy2/projects/training/mammoth/moose/libmesh/installed/contrib/bin/libmesh-config: No such file or directory
/bin/sh: /Users/wangy2/projects/training/mammoth/moose/libmesh/installed/libtool: No such file or directory
/bin/sh: /Users/wangy2/projects/training/mammoth/moose/libmesh/installed/libtool: No such file or directory
/bin/sh: /Users/wangy2/projects/training/mammoth/moose/libmesh/installed/contrib/bin/libmesh-config: No such file or directory
/bin/sh: /Users/wangy2/projects/training/mammoth/moose/libmesh/installed/contrib/bin/libmesh-config: No such file or directory
/bin/sh: /Users/wangy2/projects/training/mammoth/moose/libmesh/installed/contrib/bin/libmesh-config: No such file or directory

because we do not have libmesh built yet.

Design

It would be nice to remove these outputs. I like make libmesh_update other than running the script manually.

Impact

Better user experience.

permcody commented 5 years ago

I don't understand - all "make libmesh_update" does is run the script, so what happened here?

https://github.com/idaholab/moose/blob/next/framework/build.mk#L284-L288

YaqiWang commented 5 years ago

I think for a fresh check out libMesh has not been built yet, thus libmesh-config executable doesn’t exist. Building is ok just with some unnecessary warnings on screen.

permcody commented 5 years ago

Yes, it's definitely true that libMesh isn't built in a fresh clone, but that command just runs the update_and_rebuild_libmesh_script. It doesn't do anything else so I don't see how it's possible that you got a warning about something not existing. Did you run make first?

YaqiWang commented 5 years ago

Possibly caused by these lines? https://github.com/idaholab/moose/blob/next/framework/build.mk#L27

permcody commented 5 years ago

Ah, I see... I'll look into it. Maybe we won't be able to do this with the make target.