idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.7k stars 1.04k forks source link

JOSS PorousFlow paper amendments #14831

Closed WilkAndy closed 3 years ago

WilkAndy commented 4 years ago

Reason

@cpgr, reviewers (= @hsheldon) have suggested the following changes:

Design

Change modules/porous_flow/paper.md and modules/porous_flow/paper.bib . Probably do this after #14796 is done.

Impact

Better documentation

WilkAndy commented 4 years ago

Also, add this reference, which involves geothermal work:

Jin, W. and Podgorney, R. and McLing, T. "THM coupled numerical analysis on the geothermal energy storage and extraction in porous fractured reservoir". In 54th US Rock Mechanics Symposium, Golden, Colarado, USA, 28 June-1 July 2020, ARMA 20-1338. 1--10.

WilkAndy commented 4 years ago

Hi @cpgr , I've included the above references. What's your opinion on @hsheldon 's other comments:

cpgr commented 4 years ago

They are both good points, but I think the paper is already near the word limit isn't it? It might be hard to do both?

WilkAndy commented 4 years ago

True about the word limit

WilkAndy commented 4 years ago

@cpgr just told me that Permann paper is now published - see #14851

WilkAndy commented 3 years ago

Closed by the above commit