search

idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.78k stars 1.05k forks source link

Add information about mesh interpolation / extrapolation behavior of the SolutionUO/Function in the documentation #19238

Open GiudGiud opened 3 years ago

GiudGiud commented 3 years ago

Reason

SolutionAux has a little bit of information The rest does not. We should add more either way

Design

More docs

Impact

User friendliness

YaqiWang commented 3 years ago

@GiudGiud noticed you are adding docs for this function. Do you think the proposal in this issue by me #10126 is a good idea or not? This is the last time I ask. If not, feel free to close that issue. If you ask me, I would really want to have that.

GiudGiud commented 3 years ago

I wasnt planning such a big change. I m always an advocate for shorter input files, but here we cant afford to load the mesh multiple times with multiple UOs nested into the functions. I closed this.

YaqiWang commented 3 years ago

To be clear I was not proposing remove the UO, just merging when UO is used by one function and only by one. Function can still opt to accept an existing UO. This is just a minor irritating thing making users think why the input can not be simpler.

GiudGiud commented 3 years ago

I totally understand your concern and tend to share it. But for example for these two Griffin inputs (which maybe you have an idea to make them shorter?) you would barely notice the extra block! Work on array variables would just remove so much more of the input file.

https://github.com/idaholab/virtual_test_bed/blob/main/msr/msfr/steady/run_neutronics.i https://github.com/idaholab/virtual_test_bed/blob/main/pbfhr/steady/ss0_neutrons.i

YaqiWang commented 3 years ago

Agree!