idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.7k stars 1.04k forks source link

Add action for porous media solid heat conduction in PINSFV #21425

Open GiudGiud opened 2 years ago

GiudGiud commented 2 years ago

Reason

Action syntax shortens inputs and reduces user mistakes. It's kind of expected to exist for the solid equation at this point.

Design

In heat conduction module? In NS? In Pronghorn? I'd say NS. It's higher exposure and it's nothing ECed In a separate action or merged in the massive NSFVAction? I d say the former

Impact

Easier user input, happier users, less debugging

@lindsayad @grmnptr @snschune for thoughts / comments

lindsayad commented 2 years ago

I would say that the acronym you used in the issue title implies the answer. I agree that this should be in NS