idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.74k stars 1.05k forks source link

Document (spatial/temporal) and implement (temporal) TVD schemes for fluid flow applications #22353

Open GiudGiud opened 2 years ago

GiudGiud commented 2 years ago

Reason

Our time steppers in MOOSE are often usable across the entire framework*. But for fluid flow we want to have this total variation diminishing characteristic

We should document which schemes we have that hold this, and start deploying them in examples in the respective fluid flow applications and modules.

*Newmark-Beta for tensor mechanics might be the exception I m not very familiar

Design

More documentation Additional time integration schemes as appropriate

Impact

Higher fidelity simulations

lindsayad commented 2 years ago

This issue should make clear that it's about TVD time integration schemes. We already have TVD spatial schemes

GiudGiud commented 2 years ago

Yeah it's intertwined which is why I started with "document" A TVD scheme is really a spatial scheme that is well behaved in time, so we should possibly look at the interaction between the time scheme and the spatial scheme