idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.77k stars 1.05k forks source link

Improve documentation and exception checking around functor gap models #22513

Open GiudGiud opened 2 years ago

GiudGiud commented 2 years ago

Bug Description

We just had a user try gap radiation with FV and they made the following mistakes:

We need to document the finite volume path from the main pages (eg the constraint ones and maybe the FE page) and possibly force finite volume users to use the functor version (even though they only loose second order accuracy if they dont)

Steps to Reproduce

From fv_modular_gap_heat_transfer_mortar_radiation_conduction.i test, remove ghosting to get an error and change the gap flux models to loose second order

Impact

Better user experience

lindsayad commented 2 years ago

I wouldn't put this in an FY21 project

GiudGiud commented 2 years ago

Should we have a FY22 TH project? Would it be common layer for maintenance of FV ?

lindsayad commented 2 years ago

We have an FY23 project for the common layer. I think this is valid to put in the common layer