search

idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.77k stars 1.05k forks source link

Make error on nonzero reallocation the default #23943

Open lindsayad opened 1 year ago

lindsayad commented 1 year ago

Reason

It can be a huge performance penalty if new nonzeros are allocated by PETSc and this performance penalty occurs "silently". @roystgnr recently had to track down this performance penalty and his tracking may have been a lot quicker if he got new nonzero errors.

Design

Toggle MooseApp::errorOnJacobianNonzeroReallocation to true. This will implicitly make new nonzeros an error for all of our modules and applications. Modules and apps which rely on being able to allocate new nonzeros on the fly (this is impossible to avoid currently for contact on a displaced mesh until we can do matrices with "on-the-fly" sparsity, see https://gitlab.com/petsc/petsc/-/issues/852) will need to override this app virtual.

Impact

Less frequent silent performance penalties

lindsayad commented 1 year ago

This is an intermediate step on the way to https://github.com/idaholab/moose/issues/12397