Add proper error messages for FieldSplitPreconditioner

idaholab / moose

Multiphysics Object Oriented Simulation Environment

https://www.mooseframework.org

GNU Lesser General Public License v2.1

1.76k stars 1.05k forks source link

Add proper error messages for FieldSplitPreconditioner #25957

Open MengnanLi91 opened 12 months ago

MengnanLi91 commented 12 months ago

Reason

Right now FieldSplitPeconditioner doesn't give clear error when off_diga_rows and off_diga_columns has wrong size. It only proceeds when the sizes are correct

Design

Add detailed error messages when off_diga_rows and off_diga_columns has wrong size and add error check tests

Impact

More user-friendly

MengnanLi91 commented 12 months ago

@GiudGiud

lindsayad commented 12 months ago

did this come up in a user's input?

MengnanLi91 commented 12 months ago

did this come up in a user's input?

No this is from Guillaume's request for another PR(#25245). Check the discussion here(https://github.com/idaholab/moose/pull/25245#discussion_r1378220117)