search

idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.72k stars 1.04k forks source link

Remove HeatConductionMaterial #26703

Open lindsayad opened 8 months ago

lindsayad commented 8 months ago

Reason

It creates derivatives of material properties with respect to temperature via Function::timeDerivative which is an abuse of the Function system. We have the DerivativeMaterialInterface and DerivativeParsedMaterial which are designed to handle derivatives of material properties with respect to coupled variables

Design

Delete the material and replace its use with DerivativeParsedMaterial

Impact

Less ways to do the same thing

lindsayad commented 8 months ago

FYI @dschwen @tophmatthews

tophmatthews commented 8 months ago

SpecificHeatConductionTimeDerivative takes the DerivativeParsedMaterial for specific_heat. Which kernel should be used with a DerivativeParsedMaterial of thermal conductivity?

lindsayad commented 8 months ago

HeatConductionKernel (in the HeatConduction files)

tophmatthews commented 8 months ago

That doesn't take DerivativeParsedMaterial now, but can be modified fo sho.