idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.6k stars 1k forks source link

Added coverage for task #17134 and added functionality to loosen the registration checks on objects for task #24119 #27485

Closed sudhirv1 closed 3 weeks ago

sudhirv1 commented 3 weeks ago

Reason

Task #17134 The code coverage report, https://mooseframework.inl.gov/docs/coverage/geochemistry/index.html , shows the code coverage for geochemistry is pretty good, but can be improved

Task #24119 Regularly we have used who mispelled, copy pasted, or worse the name of their app in the registerMooseObject call. This causes a failure, when we really dont need to be failing there. We could just find it with all the names of the apps we could create, and just emit a warning "hey did you misspell the app name there?"

Design

Task #17134 Create 2 Tests. The first one tests for stress testing the handling of exceptions by creating except6.i, which tests for an inappropriate geochemical quantity. The second one tests to ensure the correct mol/kg calculation is made.

Task #24119 Create a container that holds all of the current AppNames. Ensure that this container is filled as AppNames are being created. Then create a fuzzing algorithm. Make the macro loop through the AppName container and for each string, run it into the fuzzing function along with the input string from the user to see if there's a match. If there's no match after the loop is finished we will return a prompt to the user that a non-existent AppName was entered.

Impact

Task #17134 will increase confidence in the geochemistry module and its calculations.

Task #24119 will make the software more beginner friendly by not punishing typos and spelling mistakes when inputting and AppName.