search

idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.6k stars 1k forks source link

Add ModifyElementSubdomainByVar UserObject #27487

Closed dewenyushu closed 1 week ago

dewenyushu commented 3 weeks ago

Address #27486

moosebuild commented 3 weeks ago

Job Documentation on 72e3a75 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 3 weeks ago

Job Coverage on 72e3a75 wanted to post the following:

Framework coverage

b3efaa #27487 72e3a7
Total Total +/- New
Rate 85.11% 85.11% +0.00% 96.15%
Hits 103108 103134 +26 25
Misses 18044 18044 - 1

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports - [`framework`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/framework) - [`chemical_reactions`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/chemical_reactions) - [`combined`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/combined) - [`contact`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/contact) - [`electromagnetics`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/electromagnetics) - [`external_petsc_solver`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/external_petsc_solver) - [`fluid_properties`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/fluid_properties) - [`fsi`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/fsi) - [`functional_expansion_tools`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/functional_expansion_tools) - [`geochemistry`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/geochemistry) - [`heat_transfer`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/heat_transfer) - [`level_set`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/level_set) - [`misc`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/misc) - [`navier_stokes`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/navier_stokes) - [`optimization`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/optimization) - [`peridynamics`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/peridynamics) - [`phase_field`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/phase_field) - [`porous_flow`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/porous_flow) - [`ray_tracing`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/ray_tracing) - [`rdg`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/rdg) - [`reactor`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/reactor) - [`richards`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/richards) - [`scalar_transport`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/scalar_transport) - [`solid_mechanics`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/solid_mechanics) - [`solid_properties`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/solid_properties) - [`stochastic_tools`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/stochastic_tools) - [`thermal_hydraulics`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/thermal_hydraulics) - [`xfem`](https://mooseframework.inl.gov/docs/PRs/27487/coverage/xfem)

This comment will be updated on new commits.

dewenyushu commented 2 weeks ago

@GiudGiud this should be ready :)

dewenyushu commented 2 weeks ago

@GiudGiud this should be ready (again)

hugary1995 commented 2 weeks ago

I'd suggest a different name. To have slightly more consistency with the existing CoupledVarThresholdElementSubdomainModifier, this one could be named VariableValueElementSubdomainModifier which might also be more self-explanatory.

dewenyushu commented 2 weeks ago

I'd suggest a different name. To have slightly more consistency with the existing CoupledVarThresholdElementSubdomainModifier, this one could be named VariableValueElementSubdomainModifier which might also be more self-explanatory.

Name changed!