idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.6k stars 1k forks source link

Add physics for two-phase mixture flow #27517

Open GiudGiud opened 2 weeks ago

GiudGiud commented 2 weeks ago

I'm fairly confident it's correctly reproducing the kernels, using the DumpObjectProblem with an upgrade I added

The doco on two phase mixture is a bit lacking now. It would be good to add a page in doc/content/modules/navier_stokes at some point.

Thoughts on first & other phase?

Do you prefer:

refs #22637

moosebuild commented 1 week ago

Job Documentation on b94984a wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 1 week ago

Job Coverage on b94984a wanted to post the following:

Framework coverage

d76ac1 #27517 b94984
Total Total +/- New
Rate 85.08% 85.08% -0.01% 74.58%
Hits 103117 103125 +8 44
Misses 18076 18085 +9 15

Diff coverage report

Full coverage report

Modules coverage

Navier stokes

d76ac1 #27517 b94984
Total Total +/- New
Rate 83.87% 83.73% -0.14% 71.56%
Hits 15983 16274 +291 307
Misses 3073 3162 +89 122

Diff coverage report

Full coverage report

Full coverage reports

Reports - [`framework`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/framework) - [`chemical_reactions`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/chemical_reactions) - [`combined`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/combined) - [`contact`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/contact) - [`electromagnetics`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/electromagnetics) - [`external_petsc_solver`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/external_petsc_solver) - [`fluid_properties`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/fluid_properties) - [`fsi`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/fsi) - [`functional_expansion_tools`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/functional_expansion_tools) - [`geochemistry`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/geochemistry) - [`heat_transfer`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/heat_transfer) - [`level_set`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/level_set) - [`misc`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/misc) - [`navier_stokes`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/navier_stokes) - [`optimization`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/optimization) - [`peridynamics`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/peridynamics) - [`phase_field`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/phase_field) - [`porous_flow`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/porous_flow) - [`ray_tracing`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/ray_tracing) - [`rdg`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/rdg) - [`reactor`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/reactor) - [`richards`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/richards) - [`scalar_transport`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/scalar_transport) - [`solid_mechanics`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/solid_mechanics) - [`solid_properties`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/solid_properties) - [`stochastic_tools`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/stochastic_tools) - [`thermal_hydraulics`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/thermal_hydraulics) - [`xfem`](https://mooseframework.inl.gov/docs/PRs/27517/coverage/xfem)

Warnings

This comment will be updated on new commits.

GiudGiud commented 4 days ago

going to need a volunteer @grmnptr @lindsayad @tanoret @MengnanLi91