idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.6k stars 1k forks source link

Delete heat conduction module folder #27539

Closed GiudGiud closed 1 week ago

GiudGiud commented 2 weeks ago

refs #25584

it s been 6 months since the rename and also the apps will still build even if they have not moved on, with this warning

/Users/giudgl/projects/pronghorn/moose/modules/modules.mk:80: The heat conduction module was renamed to the heat transfer module. Please update your Makefile and replace HEAT_CONDUCTION with HEAT_TRANSFER

I m doing this now because this has started to cause more and more failures in CI, due to some obscure timing of building the code which used to be fine but no longer. The script attempts to build both heat_transfer and heat_conduction, which is fine if one is done building before the other

moosebuild commented 2 weeks ago

Job Documentation on 7f4ccd4 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 2 weeks ago

Job Coverage on 7f4ccd4 wanted to post the following:

Framework coverage

e0778a #27539 7f4ccd
Total Total +/- New
Rate 85.11% 85.11% +0.00% -
Hits 103108 103109 +1 0
Misses 18044 18043 -1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports - [`framework`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/framework) - [`chemical_reactions`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/chemical_reactions) - [`combined`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/combined) - [`contact`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/contact) - [`electromagnetics`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/electromagnetics) - [`external_petsc_solver`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/external_petsc_solver) - [`fluid_properties`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/fluid_properties) - [`fsi`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/fsi) - [`functional_expansion_tools`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/functional_expansion_tools) - [`geochemistry`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/geochemistry) - [`heat_transfer`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/heat_transfer) - [`level_set`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/level_set) - [`misc`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/misc) - [`navier_stokes`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/navier_stokes) - [`optimization`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/optimization) - [`peridynamics`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/peridynamics) - [`phase_field`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/phase_field) - [`porous_flow`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/porous_flow) - [`ray_tracing`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/ray_tracing) - [`rdg`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/rdg) - [`reactor`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/reactor) - [`richards`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/richards) - [`scalar_transport`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/scalar_transport) - [`solid_mechanics`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/solid_mechanics) - [`solid_properties`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/solid_properties) - [`stochastic_tools`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/stochastic_tools) - [`thermal_hydraulics`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/thermal_hydraulics) - [`xfem`](https://mooseframework.inl.gov/docs/PRs/27539/coverage/xfem)

This comment will be updated on new commits.

moosebuild commented 2 weeks ago

Job GCC min debug on 7f4ccd4 : invalidated by @GiudGiud

fluke or nah