Closed GiudGiud closed 4 days ago
Job Documentation on e224d50 wanted to post the following:
View the site here
This comment will be updated on new commits.
So now it does the same thing MeshCollectionGenerator
does?
params.addClassDescription("Collects multiple meshes into a single (unconnected) mesh.");
Job Coverage on e224d50 wanted to post the following:
4409da | #27647 e224d5 | ||||
---|---|---|---|---|---|
Total | Total | +/- | New | ||
Rate | 85.15% | 85.14% | -0.01% | 75.71% | |
Hits | 103914 | 103955 | +41 | 53 | |
Misses | 18123 | 18139 | +16 | 17 |
Coverage did not change
framework
new line coverage rate 75.71% is less than the suggested 90.0%This comment will be updated on new commits.
The combiner has never been stitching. So imo the two objects have always been duplicating features, one with the added capability for positions (combiner) and the other one with the added check on sideset names/ids (collection). The check on sideset names/ids would have been great on the combiner too
Except now there is code to prevent a merge which the MeshCollectionGenerator does not have. The mesh collection generator will still merge sidesets/blocks with the same ids if they are either unnamed or with the same name.
Thanks for the review! This will help interns with mesh generation I m fairly confident
closes #27646
This could be stuff we push upstream to libmesh tbh. It's mostly there for blocks already.