idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.62k stars 1.01k forks source link

Add no-merge capability to mesh combiner generator #27647

Closed GiudGiud closed 4 days ago

GiudGiud commented 2 weeks ago

closes #27646

This could be stuff we push upstream to libmesh tbh. It's mostly there for blocks already.

moosebuild commented 2 weeks ago

Job Documentation on e224d50 wanted to post the following:

View the site here

This comment will be updated on new commits.

dschwen commented 1 week ago

So now it does the same thing MeshCollectionGenerator does?

params.addClassDescription("Collects multiple meshes into a single (unconnected) mesh.");

moosebuild commented 1 week ago

Job Coverage on e224d50 wanted to post the following:

Framework coverage

4409da #27647 e224d5
Total Total +/- New
Rate 85.15% 85.14% -0.01% 75.71%
Hits 103914 103955 +41 53
Misses 18123 18139 +16 17

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports - [`framework`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/framework) - [`chemical_reactions`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/chemical_reactions) - [`combined`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/combined) - [`contact`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/contact) - [`electromagnetics`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/electromagnetics) - [`external_petsc_solver`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/external_petsc_solver) - [`fluid_properties`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/fluid_properties) - [`fsi`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/fsi) - [`functional_expansion_tools`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/functional_expansion_tools) - [`geochemistry`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/geochemistry) - [`heat_transfer`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/heat_transfer) - [`level_set`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/level_set) - [`misc`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/misc) - [`navier_stokes`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/navier_stokes) - [`optimization`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/optimization) - [`peridynamics`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/peridynamics) - [`phase_field`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/phase_field) - [`porous_flow`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/porous_flow) - [`ray_tracing`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/ray_tracing) - [`rdg`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/rdg) - [`reactor`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/reactor) - [`richards`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/richards) - [`scalar_transport`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/scalar_transport) - [`solid_mechanics`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/solid_mechanics) - [`solid_properties`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/solid_properties) - [`stochastic_tools`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/stochastic_tools) - [`thermal_hydraulics`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/thermal_hydraulics) - [`xfem`](https://mooseframework.inl.gov/docs/PRs/27647/coverage/xfem)

Warnings

This comment will be updated on new commits.

GiudGiud commented 1 week ago

The combiner has never been stitching. So imo the two objects have always been duplicating features, one with the added capability for positions (combiner) and the other one with the added check on sideset names/ids (collection). The check on sideset names/ids would have been great on the combiner too

Except now there is code to prevent a merge which the MeshCollectionGenerator does not have. The mesh collection generator will still merge sidesets/blocks with the same ids if they are either unnamed or with the same name.

GiudGiud commented 4 days ago

Thanks for the review! This will help interns with mesh generation I m fairly confident