search

idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.76k stars 1.05k forks source link

Migrate the THM Controls capability to MOOSE #28948

Open joshuahansel opened 1 hour ago

joshuahansel commented 1 hour ago

Motivation

Applications have expressed interest in using THM's control logic system, which is an extension of MOOSE's controls system but allows various controls to be chained together. Griffin, which includes the THM module, cannot use this system because the control data is stored in THMProblem, which Griffin does not use.

There is a BlueCrab training in December 2024 which would greatly benefit from the simplification that this migration would provide. Therefore, the due date for this work is 11/29/2024.

Design

The current design within has a class THMControl, which inherits from Control. The control data is stored within THMProblem. If we want to just make this capability part of the Control system, and it's possible to do without breaking existing input files, we could merge THMControl into Control. Otherwise, it could remain a derived class of Control. The control data would probably be moved to TheWarehouse and the various APIs would get moved from Simulation to FEProblemBase.

Impact

New capability in MOOSE.

joshuahansel commented 1 hour ago

@jortensi @YaqiWang @loganharbour @GiudGiud