search

idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.79k stars 1.05k forks source link

Make_modular #29199

Closed moosebuild closed 7 hours ago

moosebuild commented 7 hours ago

Imported from https://github.inl.gov/ncrc/subchannel/issues/8 : @moose-ncrc created issue at Sep 14, 2020 11:09AM MST:

In GitLab by @kyriv1980 on Sep 14, 2020, 12:09

Create 4 distinct methods(crossflow calculation, summation of crossflow values, mdot/h/T calculation, pressure drop) for my SubChannel1PhaseProblem class so that the solver is easier to read. Write Crossflow matrix at the end of the calculation Read crossflow matrix at the beginning of transient solve. Remove duplicate code in SubChannelMesh.C Edit crossflow calculation to make more readable. Regold the 2 PSBT tests to account for changes in the solution vectors.

moosebuild commented 7 hours ago

@moose-ncrc commented at Sep 14, 2020 11:17AM MST:

In GitLab by @kyriv1980 on Sep 14, 2020, 12:17

created merge request !4 to address this issue

moosebuild commented 7 hours ago

Issue closed at: Jan 16, 2023 06:58PM MST by @moose-ncrc