search

idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.77k stars 1.05k forks source link

Design issue with warehouses #6719

Open permcody opened 8 years ago

permcody commented 8 years ago

Description of the enhancement or error report

I'm going through the current plethora of warnings from debug compiling on GCC and seeing interesting things. I think that having default parameters for TID parameters in the warehouse may not be the best design. It's too easy to make mistakes. Right now we don't appear to be working with the proper thread copy for dampers which is a problem. There may be other places in the framework as well.

See this method: https://github.com/idaholab/moose/blob/devel/framework/src/base/NonlinearSystem.C#L2434-L2449

Rationale for the enhancement or information for reproducing the error

Possible thread problems in the framework

Identified impact

(i.e. Internal object changes, limited interface changes, public API change, or a list of specific applications impacted)

Currently unknown

aeslaughter commented 8 years ago

The real problem is that this method (reinitIncrementforDampers) is not tested: http://mooseframework.org/docs/coverage/moose/coverage/src/base/NonlinearSystem.C.gcov.html

YaqiWang commented 8 years ago

Oh, Just realized that this TID parameter could be related with the issue I created for general user objects #6723.