idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.71k stars 1.04k forks source link

hidden stuff in PhaseField Polycrystal #9345

Closed WilkAndy closed 7 years ago

WilkAndy commented 7 years ago

Description of the enhancement or error report

My compiler gives:

In file included from /home/wil04q/projects/moose/modules/phase_field/include/userobjects/PolycrystalVoronoi.h:10:0, from /home/wil04q/projects/moose/modules/phase_field/include/userobjects/PolycrystalHex.h:10, from /home/wil04q/projects/moose/modules/phase_field/src/base/PhaseFieldApp.C:218: /home/wil04q/projects/moose/modules/phase_field/include/userobjects/PolycrystalUserObjectBase.h:62:16: warning: âvirtual libMesh::Real PolycrystalUserObjectBase::getVariableValue(unsigned int, const libMesh::Node&) constâ was hidden [-Woverloaded-virtual] virtual Real getVariableValue(unsigned int op_index, const Node & n) const ^ In file included from /home/wil04q/projects/moose/modules/phase_field/include/userobjects/PolycrystalHex.h:10:0, from /home/wil04q/projects/moose/modules/phase_field/src/base/PhaseFieldApp.C:218: /home/wil04q/projects/moose/modules/phase_field/include/userobjects/PolycrystalVoronoi.h:26:16: warning: by âvirtual libMesh::Real PolycrystalVoronoi::getVariableValue(unsigned int, const libMesh::Point&) constâ [-Woverloaded-virtual] virtual Real getVariableValue(unsigned int op_index, const Point & p) const override; ^

Please just close this issue if this is intentional. (I won't be fixing it - i have no idea what PolyCrystal is supposed to do.)

Rationale for the enhancement or information for reproducing the error

Identified impact

(i.e. Internal object changes, limited interface changes, public API change, or a list of specific applications impacted)

permcody commented 7 years ago

Thanks! This actually does need to be fixed. I'll submit a patch.