search

idaholab / pika

Phase-field snow microstructure
GNU Lesser General Public License v2.1
16 stars 25 forks source link

Fixing "MeshModifiers" error in input files of problems/snow_2d/ #151

Closed vishankkumar closed 3 years ago

vishankkumar commented 3 years ago

Dear Developer,

I was testing some examples and there was an error of "[MeshModifiers]", which were blank so I have removed it. Perhaps its a deprecated class or something still under development. Anyhow, as the block was empty there should not be any impact on the result. So would you please accept the pull request to make these changes in the default branch.

aeslaughter commented 3 years ago

Thanks! It was removed.

aeslaughter commented 3 years ago

What is your interest in Pika?

vishankkumar commented 3 years ago

I am trying to perform some phase field simulations for battery applications, where I will couple them with electrochemical equations. So, I was wondering if I should build from Pika or from phase-field module of MOOSE.

Thanks, Vishank

On Mon, Nov 30, 2020 at 5:05 PM Andrew E Slaughter notifications@github.com wrote:

What is your interest in Pika?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/idaholab/pika/pull/151#issuecomment-735879463, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHVFG6TAQQEOYHDKH6CGAUTSSO7EXANCNFSM4UE4ATGA .

aeslaughter commented 3 years ago

phase-field module, Pika is fairly old and doesn't utilize the full capability in the module

vishankkumar commented 3 years ago

Aaah okay, thanks Andrew. Then I will develop on Phase field module itself.

If I may ask a small question regarding the kernels? I followed your MOOSE workshop and learned a lot from it and to be put in one line, you have to write your kernel for each of the term and the kernels add up on default and in the .C file you have to define the precomputeQPResidual or computeQPResidual depending on the case. My question is, do you still need to worry about off diagonal terms and Jacobian terms?

Kind regards, Vishank

On Thu, Dec 3, 2020 at 12:43 AM Andrew E Slaughter notifications@github.com wrote:

phase-field module, Pika is fairly old and doesn't utilize the full capability in the module

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/idaholab/pika/pull/151#issuecomment-737562882, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHVFG6UNMHMOOZNE7XSSLF3SS3GJ7ANCNFSM4UE4ATGA .

aeslaughter commented 3 years ago

No, the tutorial uses automatic differentiation to compute those via the ADKernel class.