[DEFECT] For some ROMs especially those that use KDtree, it reaches maximum recursion times.

Jimmy-INL commented 5 years ago

the following error: 'Maximum recursion depth exceeded while calling a python object' appeared when using Gaussian polynomial with stochastic collocation.

Describe the defect errors out:'Maximum recursion depth exceeded while calling a python object' appeared when using Gaussian polynomial with stochastic collocation.

What did you expect to see happen?

nothing.

What did you see instead?

Rom was not trained.

Do you have a suggested fix for the development team?

Describe how to Reproduce Steps to reproduce the behavior:

Screenshots and Input Files Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Platform (please complete the following information):

OS: [e.g. iOS]
Version: [e.g. 22]
Dependencies Installation: [CONDA or PIP]

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or task?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

[ ] 1. If the issue is a defect, is the defect fixed?
[ ] 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
[ ] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[ ] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[ ] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

alfoa commented 4 years ago

@Jimmy-INL do you have a test case that can replicate the error?

Jimmy-INL commented 4 years ago

This was encountered by our intern, I am not sure that I will have a test case. But I remember that @PaulTalbot-INL suggested a fix for that and it worked.

idaholab / raven