Closed PaulTalbot-INL closed 6 months ago
There's a couple things I like about Method 1 (entities):
DataMining
could inherit from a BasePlot
class, without explicitly needing to show it in the input file.type
) which kind OutStream is being used.plot
or a print
type; this approach seems to allow that kind of opportunity.It also allows us to keep the existing Plot
and Print
the way they are, and is easy to build the InputData
for without checking subtypes too much.
Under Discussion Topic
With the merge of #1329 the OutStream is now an Entity much more like other RAVEN entities, with a base class that is extensible rather than a "manager" that instantiates sub-instances.
This means it should be easier to create custom printing/plotting tasks as OutStreams, such as the
dataMining
plotting that we already have.This invites us to consider how we want these to show up in the input file. There's a couple things to consider:
The existing setup for
dataMining
uses the structure:Another option would be to add each new OutStream as a distinct type, keeping
Print
andPlot
as the generic options:Other options may be worth considering, too.
For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.
For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.
task
issue?