[DEFECT] ROMCollection.Interpolated not passing deserialization params

PaulTalbot-INL commented 3 years ago

Defect Description

If using a ROMCollection.Interpolated ROM model, and passing through ROM params (such as the ARMA's clusterEvalMode), these are not currently passed to each of the Collection objects that are part of the interpolation. This means seed control, among other things, is compromised.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or task?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

[ ] 1. If the issue is a defect, is the defect fixed?
[ ] 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
[ ] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[ ] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[ ] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

PaulTalbot-INL commented 3 years ago

@alfoa do you think this warrants a user list notification?

alfoa commented 3 years ago

The feature is very young and still in beta testing. It is not really spread in the comunity so I would avoid the first email and just inform the user when the defect is addressed

idaholab / raven