idaholab / raven

RAVEN is a flexible and multi-purpose probabilistic risk analysis, validation and uncertainty quantification, parameter optimization, model reduction and data knowledge-discovering framework.
https://raven.inl.gov/
Apache License 2.0
219 stars 133 forks source link

[TASK] TSA Algorithms applied Globally and Locally in ROMCollection #2188

Closed GabrielSoto-INL closed 1 year ago

GabrielSoto-INL commented 1 year ago

Issue Description

Is your feature request related to a problem? Please describe. The TSA module applies algorithms at the segment ("local") level. If a user wants to apply the algorithms to the full signal instead ("globally"), then the <Segment> node in the XML should be omitted. However, there is no option to mix global and local applications of algorithms.

Describe the solution you'd like It would be nice to distinguish algorithms applied globally and locally in the XML script. Detrending the full signal rather than on a per-segment basis could sometimes work better. E.g., detrending Fourier modes with periods longer than the segment length would be best to do on the global signal. Users can still train, for example, ARMA models on each segment.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.


For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

dylanjm commented 1 year ago

Approved to close via #2189