idaholab / raven

RAVEN is a flexible and multi-purpose probabilistic risk analysis, validation and uncertainty quantification, parameter optimization, model reduction and data knowledge-discovering framework.

https://raven.inl.gov/

Apache License 2.0

217 stars 133 forks source link

Switches the implementation of 1D probability distributions from Crow to appropriate python libraries #2201

Closed j-bryan closed 10 months ago

j-bryan commented 10 months ago

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

2200

What are the significant changes in functionality due to this change request?

Adds an implementation of 1D probability distributions using classes from scipy.stats to replicate those of Crow (which use the Boost C++ library).

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

moosebuild commented 10 months ago

Job Test qsubs sawtooth on b1de467 : invalidated by @joshua-cogliati-inl

failed in set python environment

moosebuild commented 10 months ago

Job Test qsubs sawtooth on 22f79b4 : invalidated by @joshua-cogliati-inl

Failed with: DirectoryNotACondaEnvironmentError: The target directory exists, but it is not a conda environment.

moosebuild commented 10 months ago

Job Mingw Test on 05eb833 : invalidated by @joshua-cogliati-inl

failed in fetch

moosebuild commented 10 months ago

Job Test qsubs sawtooth on d994f5f : invalidated by @joshua-cogliati-inl

Failed with: DirectoryNotACondaEnvironmentError: The target directory exists, but it is not a conda environment.

moosebuild commented 10 months ago

Job Test qsubs sawtooth on 8e7a2cc : invalidated by @joshua-cogliati-inl

Failed with: DirectoryNotACondaEnvironmentError: The target directory exists, but it is not a conda environment.

moosebuild commented 10 months ago

Job Mingw Test on 8e7a2cc : invalidated by @joshua-cogliati-inl

Failed tests/framework/InternalParallelTests/ExternalModelRay