idaholab / raven

RAVEN is a flexible and multi-purpose probabilistic risk analysis, validation and uncertainty quantification, parameter optimization, model reduction and data knowledge-discovering framework.
https://raven.inl.gov/
Apache License 2.0
217 stars 133 forks source link

[TASK] Create a usable numpy-based random number generator #2204

Closed j-bryan closed 5 months ago

j-bryan commented 10 months ago

Issue Description

Is your feature request related to a problem? Please describe. It would be nice to not have to use the RNG in Crow. The ability to use numpy's RNG capabilities is somewhat included in ravenframework/utils/randomUtils.py, but it is not tested and cannot be used in its present state.

Describe the solution you'd like Finish the implementation of the numpy RNG so that it produces equivalent output to the Crow RNG. It could then be a drop-in replacement throughout RAVEN.

Describe alternatives you've considered Change the default RNG to numpy, but keep the Crow capabilities included. Use the Crow RNG for the existing tests, and encourage the use of the numpy RNG for future development. Otherwise, switch to the numpy RNG throughout and regold a significant number of tests.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.


For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

wangcj05 commented 5 months ago

This issue can be closed with #2205