idaholab / raven

RAVEN is a flexible and multi-purpose probabilistic risk analysis, validation and uncertainty quantification, parameter optimization, model reduction and data knowledge-discovering framework.
https://raven.inl.gov/
Apache License 2.0
217 stars 133 forks source link

Removing code obsoleted by switching to scipy distributions. #2210

Closed joshua-cogliati-inl closed 9 months ago

joshua-cogliati-inl commented 10 months ago

Pull Request Description

What issue does this change request address?

2200

What are the significant changes in functionality due to this change request?

This removes code made obsolete by #2201 and #2206, the switching from crow distributions to scipy probability distributions and switching to numpy random number generation.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

moosebuild commented 10 months ago

Job Mingw Test on 3e1d8ab : invalidated by @joshua-cogliati-inl

failed in fetch

moosebuild commented 9 months ago

Job Test qsubs sawtooth on 2787f81 : invalidated by @joshua-cogliati-inl

Failed with: DirectoryNotACondaEnvironmentError: The target directory exists, but it is not a conda environment.

moosebuild commented 9 months ago

Job Test Ubuntu 18 PIP on d6c1b80 : invalidated by @joshua-cogliati-inl

restarted civet

moosebuild commented 9 months ago

Job Test Ubuntu 18-2 Python 3 on d6c1b80 : invalidated by @joshua-cogliati-inl

restarted civet

moosebuild commented 9 months ago

Job Test Ubuntu 18-2 Python 3 on d6c1b80 : canceled by @joshua-cogliati-inl

failed with plugins

moosebuild commented 9 months ago

Job Test Ubuntu 18-2 Python 3 on d6c1b80 : invalidated by @joshua-cogliati-inl

restarted civet

moosebuild commented 9 months ago

Job Test qsubs sawtooth on 677a78e : invalidated by @joshua-cogliati-inl

Failed with: DirectoryNotACondaEnvironmentError: The target directory exists, but it is not a conda environment.

moosebuild commented 9 months ago

Job Test Fedora 31 on d6c1b80 : invalidated by @joshua-cogliati-inl

restarted civet

moosebuild commented 9 months ago

Job Test qsubs sawtooth on 677a78e : invalidated by @joshua-cogliati-inl

FAILED: Diff tests/cluster_tests/test_mpiqsub_long

moosebuild commented 9 months ago

Job Test qsubs sawtooth on 677a78e : invalidated by @joshua-cogliati-inl

Failed with: DirectoryNotACondaEnvironmentError: The target directory exists, but it is not a conda environment.

wangcj05 commented 9 months ago

one test failed:


{'pass': 177, 'fail': 1}

Running test failed with exit code 1
(388F1/890) Failed (  1.11sec)tests/framework/unit_tests/DataObjects/DataSets
moosebuild commented 9 months ago

All jobs on 7e0726c : invalidated by @wangcj05

retesting with xarray update

moosebuild commented 9 months ago

Job Test qsubs sawtooth on 7e0726c : invalidated by @joshua-cogliati-inl

Failed with: DirectoryNotACondaEnvironmentError: The target directory exists, but it is not a conda environment.

moosebuild commented 9 months ago

Job Test qsubs sawtooth on 7e0726c : invalidated by @joshua-cogliati-inl

Failed with: DirectoryNotACondaEnvironmentError: The target directory exists, but it is not a conda environment.

wangcj05 commented 9 months ago

Tests are good, and checklist is good.