RAVEN is a flexible and multi-purpose probabilistic risk analysis, validation and uncertainty quantification, parameter optimization, model reduction and data knowledge-discovering framework.
Recent changes to RNG interface in RAVEN have broken signal generation in ravenframework/TSA/MarkovAR.py. This wasn't caught by the existing test because samples from the model were not checked in the regression test.
Steps to Reproduce
The existing test case (tests/framework/ROM/TimeSeries/SyntheticHistory/markov_ar.xml) reproduces the error.
Expected Behavior
Generation of a signal with the fitted model. Execution of the current code results in an AttributeError.
Screenshots and Input Files
No response
OS
Windows
OS Version
No response
Dependency Manager
CONDA
For Change Control Board: Issue Review
[x] Is it tagged with a type: defect or task?
[x] Is it tagged with a priority: critical, normal or minor?
[x] If it will impact requirements or requirements tests, is it tagged with requirements?
[x] If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)
For Change Control Board: Issue Closure
[x] If the issue is a defect, is the defect fixed?
[x] If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
[x] If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
dylanjm
commented
9 months ago
Thank you for the defect report
RAVEN.Defect Description
Recent changes to RNG interface in RAVEN have broken signal generation in
ravenframework/TSA/MarkovAR.py. This wasn't caught by the existing test because samples from the model were not checked in the regression test.Steps to Reproduce
The existing test case (
tests/framework/ROM/TimeSeries/SyntheticHistory/markov_ar.xml) reproduces the error.Expected Behavior
Generation of a signal with the fitted model. Execution of the current code results in an
AttributeError.Screenshots and Input Files
No response
OS
Windows
OS Version
No response
Dependency Manager
CONDA
For Change Control Board: Issue Review
For Change Control Board: Issue Closure