idaholab / raven

RAVEN is a flexible and multi-purpose probabilistic risk analysis, validation and uncertainty quantification, parameter optimization, model reduction and data knowledge-discovering framework.
https://raven.inl.gov/
Apache License 2.0
217 stars 133 forks source link

Addressed inconsistency between RFE-DMDc and GA-DMDc #2231

Closed alfoa closed 8 months ago

alfoa commented 9 months ago

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #2230

What are the significant changes in functionality due to this change request?

Extraction of PR #2224:

•   Identified the reason to have inconsistent score between RFE-DMDc and GA-DMDc.
•   The avgArray and stdArray need to be calculated for each realization. That's the reason of inconsistency.

No new test is added since the inconsistency does not modify the search pattern of the algorithm


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

moosebuild commented 9 months ago

Job Test Ubuntu 18 PIP on 6d49205 : invalidated by @alfoa

wangcj05 commented 8 months ago

checklist is good.