idaholab / raven

RAVEN is a flexible and multi-purpose probabilistic risk analysis, validation and uncertainty quantification, parameter optimization, model reduction and data knowledge-discovering framework.
https://raven.inl.gov/
Apache License 2.0
216 stars 132 forks source link

Wangc/bison interface #2274

Closed wangcj05 closed 5 months ago

wangcj05 commented 5 months ago

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

This PR will address the following issues:

close #2159 close #1609 close #2080

What are the significant changes in functionality due to this change request?

Allow moose interface to accept top level variables, as well as some improvements on how to output csv file.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

moosebuild commented 5 months ago

Job Mingw Test on fa76b9d : invalidated by @joshua-cogliati-inl

failed in fetch

moosebuild commented 5 months ago

Job Mingw Test on fa76b9d : invalidated by @wangcj05

timeout

moosebuild commented 5 months ago

Job Mingw Test on fa76b9d : invalidated by @wangcj05

fetch issue

moosebuild commented 5 months ago

Job Mingw Test on fa76b9d : invalidated by @wangcj05

some issues with test machines

wangcj05 commented 5 months ago

Hi @PaulTalbot-INL and @joshua-cogliati-inl, can any of you have time to review this PR?

wangcj05 commented 5 months ago

@PaulTalbot-INL Thanks for your comments, I have resolved your comments.

PaulTalbot-INL commented 5 months ago

Good to merge if tests pass without further changes.