Support of pip installation of repo via pip. Closes #2276

alfoa commented 5 months ago

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #2276

What are the significant changes in functionality due to this change request?

Addition of the possibility in the library_hadler to accept a keyword "repo" to indicate that a dependency should be installed from a GitHub repository directly (using pip install git+https)

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

moosebuild commented 5 months ago

Job Test CentOS 8 on e9e6f83 : invalidated by @wangcj05

envs issue

joshua-cogliati-inl commented 5 months ago

Hm, can you give an example of how this would be used (sample dependencies.xml?) Thanks.

moosebuild commented 5 months ago

Job Test qsubs sawtooth on e9e6f83 : invalidated by @alfoa

moosebuild commented 5 months ago

Job Test CentOS 8 on e9e6f83 : invalidated by @alfoa

alfoa commented 5 months ago

Hm, can you give an example of how this would be used (sample dependencies.xml?) Thanks.

Absolutely. Here it as an example:

<dependencies>
  <main>
    <networkx/>
    <pytest/>
    <pyomo source='forge'/>
    <glpk source='forge' skip_check='True'/>
    <shapely source="pip"/>
    <armi source="pip"  repo="https://github.com/terrapower/armi.git"/>
  </main>

</dependencies>

alfoa commented 5 months ago

@alfoa This PR looks good to me. One suggestion is to put an example in our dependency file (using commented lines), since we do not have documentation for library handling.

@joshua-cogliati-inl Do you have any comments on this PR?

Perfect. Added

wangcj05 commented 4 months ago

PR checklist is good. PR can be merged.

idaholab / raven