[TASK] Allow functions in samplers/optimizers to be implemented in the same python module

alfoa commented 5 months ago

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #2300

What are the significant changes in functionality due to this change request?

This PR Allows functions in samplers/optimizers to be implemented in the same python module. The old approach (method named ``evaluate'' is still available) but a new approach where a method named like the function is implemented.

@wangcj05 @mandd @idaholab/raven-team This is a modification I did in my local version and I thought it could be useful. Feel free to close/discard this feature/PR.

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

moosebuild commented 5 months ago

Job Mingw Test on f85cedd : invalidated by @alfoa

moosebuild commented 5 months ago

Job Mingw Test on f85cedd : invalidated by @aalfonsi

alfoa commented 5 months ago

@wangcj05 @mandd @joshua-cogliati-inl the windows machine does not seem to work

moosebuild commented 5 months ago

Job Mingw Test on f85cedd : invalidated by @wangcj05

moosebuild commented 5 months ago

Job Mingw Test on f85cedd : invalidated by @joshua-cogliati-inl

failed in fetch

moosebuild commented 5 months ago

Job Mingw Test on f85cedd : invalidated by @alfoa

fetch error

wangcj05 commented 5 months ago

@alfoa FYI, our HPC is under maintenance right now. This outage will last until May 6. Please let me know if you need to merge this PR before that.

alfoa commented 5 months ago

@alfoa FYI, our HPC is under maintenance right now. This outage will last until May 6. Please let me know if you need to merge this PR before that.

@wangcj05 No problem for me. I can use my local branch for now. Let me know if you have comments on this in the meanwhile (that I can address offline).

Thanks a lot

moosebuild commented 5 months ago

Job Mingw Test on f85cedd : invalidated by @joshua-cogliati-inl

failed in fetch

wangcj05 commented 5 months ago

Checklist is good, PR can be merged.

wangcj05 commented 5 months ago

@alfoa Thanks for your contribution, I have merged your PR.

idaholab / raven