SimulatedAnnealing Discrete Variables

alfoa commented 5 months ago

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #2305

What are the significant changes in functionality due to this change request?

Addition of the support for simulated annealing of discrete variables. In order to minimize the modifications, the discrete variables are treated using cdf sampling and inverseCDF transformation.

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

moosebuild commented 5 months ago

Job Precheck on a794170 : invalidated by @joshua-cogliati-inl

failed because of hpcgitlab being down

alfoa commented 4 months ago

@Jimmy-INL @wangcj05 this is ready for review

alfoa commented 4 months ago

@wangcj05 all tests fail now for the issue seen in #2317 with cvxpy

moosebuild commented 4 months ago

All jobs on 28624b8 : invalidated by @wangcj05

moosebuild commented 4 months ago

Job Mingw Test on de67311 : invalidated by @alfoa

fetch failure

moosebuild commented 4 months ago

Job Test qsubs sawtooth on de67311 : invalidated by @alfoa

moosebuild commented 4 months ago

Job Mingw Test on 44192fa : invalidated by @wangcj05

wangcj05 commented 4 months ago

Changes are good. PR checklists are good

idaholab / raven