idaholab / raven

RAVEN is a flexible and multi-purpose probabilistic risk analysis, validation and uncertainty quantification, parameter optimization, model reduction and data knowledge-discovering framework.

https://raven.inl.gov/

Apache License 2.0

212 stars 131 forks source link

Removing specifying liblapack. #2327

Closed joshua-cogliati-inl closed 1 month ago

joshua-cogliati-inl commented 1 month ago

Pull Request Description

What issue does this change request address?

1806

(See also pull requests: #2260 #2251 )

What are the significant changes in functionality due to this change request?

This removes the specification of liblapack for Mac and Linux, since newer versions of liblapack work with RAVEN again. This also forces setuptools 69 because version 70 does not work with the version of ray we use.

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

moosebuild commented 1 month ago

Job Test Ubuntu 16 on 203b38c : invalidated by @joshua-cogliati-inl

failed in fetch

moosebuild commented 1 month ago

Job Test mac on 203b38c : invalidated by @joshua-cogliati-inl

failed in fetch

moosebuild commented 1 month ago

Job Mingw Test on 203b38c : invalidated by @joshua-cogliati-inl

updated conda

moosebuild commented 1 month ago

Job Mingw Test on 203b38c : invalidated by @joshua-cogliati-inl

updated conda

moosebuild commented 1 month ago

Job Test Ubuntu 20-2 Optional on 203b38c : invalidated by @joshua-cogliati-inl

updated conda

moosebuild commented 1 month ago

Job Test Ubuntu 18-2 Python 3 on 0e90fda : invalidated by @joshua-cogliati-inl

Diff tests/framework/PostProcessors/LimitSurface/testLimitSurfacePostProcessor

moosebuild commented 1 month ago

Job Mingw Test on 07fb9c9 : invalidated by @joshua-cogliati-inl

failed in fetch

moosebuild commented 1 month ago

Job Test qsubs sawtooth on 07fb9c9 : invalidated by @joshua-cogliati-inl

Diff tests/cluster_tests/AdaptiveSobol/test_parallel_adaptive_sobol

joshua-cogliati-inl commented 1 month ago

Note that the windows dependency on a specific liblapack can be removed with a regold at some point in the future.

wangcj05 commented 1 month ago

Tests are green, checklist is good.