idaholab / raven

RAVEN is a flexible and multi-purpose probabilistic risk analysis, validation and uncertainty quantification, parameter optimization, model reduction and data knowledge-discovering framework.
https://raven.inl.gov/
Apache License 2.0
218 stars 133 forks source link

Workshop2024 merge #2328

Closed PaulTalbot-INL closed 2 months ago

PaulTalbot-INL commented 4 months ago

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

close #2339

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

wangcj05 commented 3 months ago

@joshua-cogliati-inl It seems there is some problem with IDW rom:

image

Do you have time to take a look at it? You can check test at:

image
joshua-cogliati-inl commented 3 months ago

@joshua-cogliati-inl It seems there is some problem with IDW rom:

Hm, I wonder if commenting out line 234 in crow/include/utilities/ND_Interpolation_Functions.h would fix it. (That is virtual ~InverseDistanceWeighting() {}; )

@j-bryan or @mandd (Any ideas?)

It looks like the Constructors in src/utilities/inverseDistanceWeigthing.cxx do not have any allocation, so I am not sure why a destructor would be needed.

j-bryan commented 3 months ago

@joshua-cogliati-inl I tried commenting out that line, rebuilding RAVEN, and running the test, and I still got that warning.

wangcj05 commented 2 months ago

@joshua-cogliati-inl FYI, I have reduced the sizes of slides based on your suggestion using print option.

wangcj05 commented 2 months ago

This PR only touches workshop materials, and there is no source code updates in this PR. Since HPC is under maintenance, the Test qsubs sawtooth can be skipped in this PR. Once other tests are green, this PR can be merged.