idaholab / raven

RAVEN is a flexible and multi-purpose probabilistic risk analysis, validation and uncertainty quantification, parameter optimization, model reduction and data knowledge-discovering framework.
https://raven.inl.gov/
Apache License 2.0
217 stars 133 forks source link

Fixed multi-word arguments bug in run_tests #2340

Closed caleb-sitton-inl closed 1 month ago

caleb-sitton-inl commented 2 months ago

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #2338

What are the significant changes in functionality due to this change request?

This change allows run_tests to forward command line arguments that contain spaces to rook successfully. Instead of saving the entire command for rook in a string variable, then calling the string variable as a command, this update calls the command directly. In the Plugins section, this requires that the command be repeated (copy/pasted), since in the previous version of run_tests the string of the rook command was printed before being called. Functionality should not change for typical run_tests usage with this update.

Admittedly, this solution introduces code with suboptimal style. Nevertheless, of all options, this is likely the stylistically best solution that effectively solves the problem. Various alternative solutions were attempted that would not require modifying run_tests, including placing the multi-word argument to run_tests in single quotes instead of double quotes (e.g. ./run_tests --arg-for-rook='content to be passed to rook'), escaping double quote characters in the argument to run_tests (e.g. ./run_tests --arg-for-rook=\"content to be passed to rook\"), and escaping space characters in the argument to run_tests (e.g. ./run_tests --arg-for-rook="content\ to\ be\ passed\ to\ rook"). None were effective.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

moosebuild commented 1 month ago

Job Test Fedora 32 on 2780d1c : invalidated by @GabrielSoto-INL

problem cloning raven