idaholab / stork

DEPRECATED
10 stars 405 forks source link

Make make_new_application.py compatible with both python2 and python3 #40

Closed lindsayad closed 7 years ago

lindsayad commented 8 years ago
friedmud commented 8 years ago

I'm not for this change (but I can be overruled).

The entire MOOSE ecosystem depends on Python2. We shouldn't give any false hope of anything ever working with Python3.

Years from now we'll do a "big switch"... but that time isn't here yet.

permcody commented 8 years ago

As long as it's backwards compatible, this is fine. We've had people put in Python3 "fixes" before that do NOT work with python 2.6 (our current minimum version). That'll be the test for this one PR before we merge.

Thanks Alex!

lindsayad commented 8 years ago

Thanks Cody.

If the goal is to be compatible with python 2.6, then the call to subprocess.check_output here is going to produce an AttributeError.

lindsayad commented 8 years ago

In terms of stork use, the only evidence I have of people trying (and failing) to use a python version < 2.7 comes from the message board: https://groups.google.com/forum/#!searchin/moose-users/subprocess.check_output%7Csort:relevance/moose-users/qq9KhzfQF98/a-pAMdxx5MYJ, where @permcody suggests he's using "a very old version of python" :-) Are we sure we need to be backwards compatible with versions < 2.7?

permcody commented 8 years ago

touché...

We upped our minimum version to 2.7 somewhat recently but I had forgotten. Thanks for digging that up.

On Thu, Aug 18, 2016 at 11:52 AM Alex Lindsay notifications@github.com wrote:

In terms of stork use, the only evidence I have of people trying (and failing) to use a python version < 2.7 comes from the message board: https://groups.google.com/forum/#!searchin/moose-users/subprocess.check_output%7Csort:relevance/moose-users/qq9KhzfQF98/a-pAMdxx5MYJ, where @permcody https://github.com/permcody suggests he's using "a very old version of python" :-) Are we sure we need to be backwards compatible with versions < 2.7?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/idaholab/stork/pull/40#issuecomment-240802788, or mute the thread https://github.com/notifications/unsubscribe-auth/AC5XIARlZYZEi8BnvPAazz_d7h0Gsoteks5qhJvvgaJpZM4JnGm0 .

lindsayad commented 8 years ago

I assume that you're going to test on your end? I've tested on both 2.7 and 3.5

lindsayad commented 7 years ago

This is deprecated, so I don't care anymore.