idaholab / virtual_test_bed

The National Reactor Innovation Center's (NRIC) Virtual Test Bed Repository
Creative Commons Attribution 4.0 International
49 stars 67 forks source link

GCMR missing certain dimensions on Model Description Page #309

Closed lewisgross1296 closed 8 months ago

lewisgross1296 commented 9 months ago

Description

I am working on modeling the VTB GCMR, and I noticed the model description was missing information about the moderator compact radius and thickness of the FeCrAl envelope. I was able to get it after doing some investigating, but I believe these details should be added to the linked page. This isn't exactly a "bug" but bug report was the closest option in the issue templates.

Impact

This slows down others who would want to model this system, as they'd have to do some digging when it would be fairly easy to add these details to the page.

Further on

Another small nitpick would be that it would be useful to provide more info about the TRISO and B4C particles on this page, but that one is more up for debate if it is worth including. Could argue people should choose from the literature for their model, though I'd argue having a centralized list of radii/materials is better for cross-code comparison.

GiudGiud commented 9 months ago

I m all in favor of more documentation. Can you add those or do we need to contact the original authors of the model to help here?

lewisgross1296 commented 9 months ago

The YH2 moderator radius I'm using is 0.95 cm. The FeCrAl envelope thickness is 0.05 cm. I reached out to @nstauff for these, so it would be good for him to confirm. For the TRISO particles, I'm using these radii for each spherical shell region

r_fuel_kernel = 212.5e-4 # cm
r_Buffer = 312.5e-4 # cm
r_PyC1_inner = 352.5e-4 # cm
r_SiC = 387.5e-4 # cm
r_PyC2_outer = 427.5e-4 # cm

For the poison particles, I'm using these radii

r_B4C_kernel = 0.0100 # cm (100 microns of B4C)
r_poison_buff = 0.0118 # cm (18 microns of graphite buffer)
r_poison_PyC1_outer = 0.0141 # cm (23 microns of PyC1)
nstauff commented 9 months ago

@lewisgross1296 - thanks for proposing some improvement to the documentation. Some clarification:

lewisgross1296 commented 9 months ago

Thanks for the corrections! I can make a PR to update the docs (gonna be after the PHYSOR deadline though)

lewisgross1296 commented 8 months ago

Wanted to double check, but the Cr coating is natural Chromium (see attached abundances)? I'm using a density of 7.15 g/cm^3 (what I could find on Wikipedia), though that is at room temperature.

natural_Cr
nstauff commented 8 months ago

Thanks - I am using Cr density of 7.19g/cc The abundance of Cr isotopes are correct.