search

idan / gistio

A gist-backed pretty display for markdown.
https://gist.io
MIT License
485 stars 41 forks source link

Newlines converted to BR tags #63

Closed barraponto closed 5 years ago

barraponto commented 10 years ago

Gist.io is currently converting newlines in markdown to BR tags, but that's not the behavior that Github uses in http://gist.github.com

Examples: https://gist.github.com/barraponto/7450314/ and http://gist.io/7450314

barraponto commented 10 years ago

This issue stems from the commit 0252440 which starts rendering stuff as GithubFormattedMarkdown. As the documentation says:

In GFM mode, hard line breaks are always taken into account, and issue and user mentions are linked accordingly.

However, I don't see a reason to use such mode as the default. Neither does the Github API, which defaults to regular markdown. Of course, having a context to reference issues, users and commits would be great, provided there was some metadata to inform the Markdown API. Otherwise, it'd be best to stick to regular Markdown.

barraponto commented 10 years ago

Oh and I have to reinforce that regular line breaks in markdown were always ignored, which is great for the 80-chracter-line geeks (like myself). It might make sense for Github textfields, but not for text-editor/code-editor environments.

Potherca commented 5 years ago

@idan ✔️ Issue can be closed.

Looking at https://gist.io/@barraponto/7450314/ everything looks like it is rendered as expected (i.e. newlines are ignored as in the Gist).