idan / gistio

A gist-backed pretty display for markdown.
https://gist.io
MIT License
488 stars 41 forks source link

changed url matching to word characters [A-Za-z0-9] #67

Open ghost opened 10 years ago

ghost commented 10 years ago

Gist ID's now include more then characters ([A-Za-z]), but also digits ([A-Za-z0-9]).

idan commented 10 years ago

@MarkKettner are they fully alphanumeric or is it hex? Have you seen anything outside of [A-Fa-f0-9]?

ghost commented 10 years ago

@idan I just created a few to test and you appear correct, they are all hexadecimal digits

idan commented 10 years ago

Hmm, okay—just tried, and it looks like github's actual change is to make public gist identifiers the same format as private ones: 20 char hex strings. This is problematic in that there's no way to differentiate between the public gists (which we support) and the private ones (which would require some work to support) at the URL level.

BukhariH commented 10 years ago

@idan Can you go ahead and still merge this for now because as of now it's no longer working with any new gists.

causal-agent commented 10 years ago

+1

shapeshed commented 10 years ago

Yup. New gists no longer work :-(

antoinelyset commented 10 years ago

:+1:

yunga commented 10 years ago

:+1:

miniops commented 10 years ago

+1

clrh commented 10 years ago

+1

szexigexi commented 10 years ago

please merge this

mikejholly commented 10 years ago

gist.io hasn't been working in a while. Is this project abandoned? I really want to use the tool.

causal-agent commented 10 years ago

The maintainer:

image

:disappointed:

BukhariH commented 10 years ago

@programble You could try to reach him at: https://twitter.com/idangazit

causal-agent commented 10 years ago

@BukhariH I've emailed him offering to take over maintenance of this project.

BukhariH commented 10 years ago

@programble Nice! Good Luck!

nwjlyons commented 10 years ago

I'm not sure if @idan is using this repo anymore. There appears to be a Flask version of this site called gistio.py in the same repo which contains an extra view at /int:id/content which appears to be live http://gist.io/3135754/content. It is also referenced in the Procfile

The Django site in this repo doesn't contain a view at that path and I tried running the Flask version locally but the templates are still in Django format as opposed to Jinga2. So theres quite a few template syntax errors. I doubt this version of the codebase is the one that is deployed.

dajare commented 10 years ago

It appears that the Gist API only returns content for public gists "with a token", although I might be misunderstanding.

Even so, the API also returns "public": true, or "public": false, so surely the easiest way to implement this is to pick up @MarkKettner's update, and add a test for the "public" value to prevent private gists from being gistio'ed.

Gist.io is too good to go away! :(

pretty

x3ro commented 10 years ago

@mikejholly @programble @dajare I've forked gist.io to draft.sx and have already implemented support for current public and private gist urls (as far as I've tested). I'd welcome other contributors :smile:

jeremejazz commented 6 years ago

:+1: