search

idanarye / bevy-yoleck

Your Own Level Editor Creation Kit
Other
169 stars 11 forks source link

Add support for bevy::reflect::Reflect #27

Closed naomijub closed 1 year ago

naomijub commented 1 year ago

Please add Bevy::reflect support for exposed field that can be managed from client side. Maybe feature flag it

idanarye commented 1 year ago

What components need to be Reflect though? Yoleck defines quite a few:

The ones used for the core Yoleck functionality:

Most of them are marker components, so I'm not sure how useful it is to have reflection on them. YoleckRawEntry and YoleckManaged are the exception, but they mostly contain semi-structured data and I'm not sure how well reflection would work for them.

Then there are the Vpeol components (the ones used for visually editing entities in 2D/3D worlds). Many of them are only useful in the editor itself, so I don't see a reason to add reflection to them:

Then there are the ones that contain data that actually affect the entities in the game:

But since Yoleck already provides a way to edit them (that's the whole point) - why do we need reflection?

naomijub commented 1 year ago

To what I'm working with, must haves would be:

However, nice to haves would be:

But since Yoleck already provides a way to edit them (that's the whole point) - why do we need reflection?

We need a way to edit them outside the Yoleck Editor, we are only partially using Yoleck. Dou you need me to create a PR for this?