idanarye / rust-typed-builder

Compile-time type-checked builder derive
https://crates.io/crates/typed-builder
Apache License 2.0
904 stars 52 forks source link

Additional generic traits for setters #131

Open radekvit opened 9 months ago

radekvit commented 9 months ago

Is there a way to add additional generics bounds on field setters?

This would help in cases where setting bounds in the struct definition is annoying (which is most of the time), but the structure only makes sense with specific trait bounds. In my use-case, I use () as the alternative to a T: SomeTrait, and only implement functionality for T: SomeTrait. The setter is only useful in cases where the T implements some additional traits.

use typed_builder::TypedBuilder;

#[derive(TypedBuilder)]
struct Generic<T: Default> {
    //                                      vvv The new syntax could be something like this
    #[builder(default, setter(strip_option, generic_bounds = Send + Sync))]
    optional_thing: Option<T>,
}

struct Defaults(*const i32);

impl Default for Defaults {
    fn default() -> Self {
        Self(&0 as *const i32)
    }
}

fn foo() {
    // ERROR: .optional_thing can only be called with T that's Default + Send + Sync
    Generic::builder().optional_thing(Defaults::default());
}
idanarye commented 9 months ago

Why not just add the bounds on the generic when defining it?

#[derive(TypedBuilder)]
struct Generic<T: Default + Send + Sync> {
radekvit commented 9 months ago

Because T doesn't necessarily have to have those bounds - they're only important if they're set.

Consider a bound MyCustomTrait, where T can be either T: MyCustomTrait, or (). I'll only want to set the Option to Some when T is not (), and it needs to implement the trait.