woab::run_actix_inside_gtk_event_loop currently returns a Result<glib::source::SourceId, std::io::Error>. In #46 I have to remove the SourceId because I need it for woab::close_actix_runtime and it's unclonable. This is a small change - I don't think anyone was actually using it. But the Error is also redundant - it comes from an older version of Actix where I needed to call tokio::runtime::Runtime::new() and this was the only thing that could return the error - but since WoAB 0.3 I'm creating an Actix system instead of a Tokio runtime, and this can't fail (it can probably panic though? But that's irrelevant for this discussion)
Since 0.6 is going to be a big breaking change anyway (because it upgrades gtk-rs to 0.14 which made lots of breaking changes in the API), I want to take this opportunity and introduce another breaking change - removing the return value of woab::run_actix_inside_gtk_event_loop.
woab::run_actix_inside_gtk_event_loop
currently returns aResult<glib::source::SourceId, std::io::Error>
. In #46 I have to remove theSourceId
because I need it forwoab::close_actix_runtime
and it's unclonable. This is a small change - I don't think anyone was actually using it. But theError
is also redundant - it comes from an older version of Actix where I needed to calltokio::runtime::Runtime::new()
and this was the only thing that could return the error - but since WoAB 0.3 I'm creating an Actix system instead of a Tokio runtime, and this can't fail (it can probably panic though? But that's irrelevant for this discussion)Since 0.6 is going to be a big breaking change anyway (because it upgrades gtk-rs to 0.14 which made lots of breaking changes in the API), I want to take this opportunity and introduce another breaking change - removing the return value of
woab::run_actix_inside_gtk_event_loop
.