idangozlan / verdaccio-bitbucket

BitBucket auth plugin for verdaccio
MIT License
7 stars 17 forks source link

Allow to configure a default mail-domain for the username #11

Closed drothmaler closed 5 years ago

drothmaler commented 6 years ago

Add a new "defaultMailDomain" option to the configuration.

This is very handy, when all users of the NPM-Registry have the same mail domain (e. g. in companies). This way you can avoid the ugly "@" --> ".." replacement convention for user verdaccio user names.

drothmaler commented 5 years ago

@idangozlan after ignoring this PR for months you are now just closing it - without any comment?!?!?! This is not a great way of encouraging people to contribute...

idangozlan commented 5 years ago

My bad, I confused with another PR. Can you please make sure you cover it with tests?

oeph commented 5 years ago

@idangozlan any ETA on this?