search

idank / bashlex

Python parser for bash
GNU General Public License v3.0
561 stars 94 forks source link

LICENSE file location too aggressive #39

Closed ifduyue closed 5 years ago

ifduyue commented 5 years ago

https://github.com/idank/bashlex/blob/90175280afdc4f9a96c587866e64a2189cb5ce8f/setup.py#L42

(root) # pip install bashlex

LICENSE put at /usr/local/LICENSE

(root) # pip install --user bashlex

LICENSE put at /root/.local/LICENSE

(venv) $ pip install bashlex

LICENSE put at venv/LICENSE

None of these locations seems related to bashlex at first glance.

I think this is too aggressive. Considering LICENSE file is included in tarball, and after installing bashlex LICENSE file can be found in site-packages/bashlex-0.13.dist-info/LICENSE, is this still necessary?

ifduyue commented 5 years ago

I think a better approach is including LICENSE in MANIFEST.in

YannickJadoul commented 5 years ago

+1 to this; this seems to be causing problems with the normal installation procedure on macOS on Travis CI, as well: https://github.com/joerick/cibuildwheel/issues/127